Skip to content

Fix external renderers example #12841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

johanvdw
Copy link
Contributor

  • libffi-dev is required for building jupyter

  • matplotlib can not be installed using wheels on the used version of alpine
    linux, which means it must be compiled and a large number of other packages
    have to be installed as well.
    This is very inefficient: see eg.
    https://pythonspeed.com/articles/alpine-docker-python/

    Apart from that, matplotlib is actually not required for rendering
    notebook files in gitea and it will pull in other dependencies which take some
    time to build (ie numpy).

* libffi-dev is required for building jupyter
* matplotlib can not be installed using wheels on the used version of alpine
  linux, which means it must be compiled and  a large number of other packages
  have to be installed as well.
  This is very inefficient: see eg.
  https://pythonspeed.com/articles/alpine-docker-python/

  Apart from that, matplotlib is actually not required for rendering
  notebook files in gitea and it will pull in other dependencies which take some
  time to build (ie numpy).
@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Sep 14, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 14, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #12841 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12841      +/-   ##
==========================================
- Coverage   43.17%   43.17%   -0.01%     
==========================================
  Files         654      654              
  Lines       72218    72218              
==========================================
- Hits        31182    31179       -3     
- Misses      35985    35987       +2     
- Partials     5051     5052       +1     
Impacted Files Coverage Δ
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
modules/queue/workerpool.go 58.77% <0.00%> (-1.23%) ⬇️
services/pull/check.go 47.69% <0.00%> (-0.77%) ⬇️
services/pull/pull.go 42.03% <0.00%> (+0.46%) ⬆️
modules/log/event.go 59.43% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2bdf4...21194da. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 14, 2020
@techknowlogick techknowlogick merged commit 08a905f into go-gitea:master Sep 14, 2020
@johanvdw johanvdw deleted the fix_external_renderers branch September 25, 2020 17:37
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants