Fix ipv6 parsing #12321
Merged
Fix ipv6 parsing #12321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lafriks
approved these changes
Jul 25, 2020
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Jul 25, 2020
GiteaBot
added
lgtm/done
|
🚀 |
6543
reviewed
Jul 26, 2020
Co-authored-by: 6543 <[email protected]>
|
🚀 |
6543
approved these changes
Jul 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10138
[::1]in the original issue is not a correct ipv6 literal. Brackets may only be placed when also specifying a port.This PR fixes the issue when you use
::1for theHTTP_ADDRFixes #7509
Makes sure brackets are set when needed.