SSH address broken if IPv6 is used

[fakuivan]

• Gitea version (or commit ref): 1.10.0+dev-59-gf1ca8ed04
• Git version (server): 2.22.0
• Operating system: Docker (Linux 7ca71e51f279 4.15.0-54-generic Integrated dependency manager #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 Linux)
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist: Not relevant

Description

IPv6 addresses for ssh passed as SSH_DOMAIN gets cut (on the UI side at least) to the first : presumably because the algorithm used to split the port number and address splits from left to right with no limit as to how many times it should do it.

I'm not familiar with golang or the framework used in this case, but I think the error has something to do with this

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.