Fix repolist icons #12228
Merged
Fix repolist icons #12228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Something for later (after extracting to standalone vue component): https://github.com/visualfanatic/vue-svg-loader (It'll require some webpack fiddling to import multiple versions of the same svg file. I know https://github.com/facebook/create-react-app has solved to using |
GiteaBot
added
the
lgtm/need 2
silverwind
force-pushed
the
dashicons
branch
3 times, most recently
from
25d25ed to
d6e11f5
Compare
zeripath
approved these changes
Jul 12, 2020
GiteaBot
added
lgtm/need 1
zeripath
reviewed
Jul 12, 2020
silverwind
commented
Jul 12, 2020
lafriks
approved these changes
Jul 12, 2020
GiteaBot
added
lgtm/done
lafriks
added
type/bug
skip-changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should really extract this file to its own .vue template as having multiple template languages in one file is majorly confusing.
Fixes: #12226