Octicons are missing for dashboard repolist

[CirnoT]

• Gitea version (or commit ref): bac57ab
• Git version: gitea:latest
• Operating system: gitea:latest
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

#12157 introduced direct SVG rendering however no appropriate changes were made to dashboard repolist

gitea/templates/user/dashboard/repolist.tmpl

Line 64 in bac57ab

<label><svg class="svg octicon-lock" width="16" height="16" aria-hidden="true"><use xlink:href="#octicon-lock" /></svg>{{.i18n.Tr "home.show_private"}}</label>

[silverwind]

There's more:

gitea/templates/user/dashboard/repolist.tmpl

Line 106 in bac57ab

<svg :class="'svg ' + repoClass(repo)" width="16" height="16" aria-hidden="true"><use :xlink:href="'#' + repoClass(repo)" /></svg>

A template language inside another template language. I don't think it's such a great idea.

[silverwind]

I really wonder why there is even vue templates mixed in the go templates using pseudo-global JS functions. Those should be standalone .vue files.