fix #1189, commit messages containing a pipe #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rewrite the commit log to include the identifier of the commit being backported ? |
tboerger
added
the
lgtm/need 2
|
backport from #1203 |
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Mar 16, 2017
|
LGTM |
tboerger
added
lgtm/done
|
@philfry maybe you can rebase this. |
|
let L-G-T-M work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch makes
graphItemFromStringsplit only the first 8 elements, leaving commit messages with pipes in it untouched.(backport for release/v1.1)