For language detection do not try to analyze big files by content #11971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
approved these changes
Jun 19, 2020
GiteaBot
added
the
lgtm/need 1
Member
|
Should probably make this configurable. |
Member
Author
|
@silverwind that could be improved in other PR. Currently this is just bugfix |
CirnoT
approved these changes
Jun 19, 2020
GiteaBot
added
lgtm/done
Member
Author
|
🚀 |
lafriks
added a commit
to lafriks-fork/gitea
that referenced
this pull request
Jun 19, 2020
lafriks
added a commit
that referenced
this pull request
Jun 19, 2020
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when using Reader go-git will still load file content into memory. Limit language statistics to not analyze files larger than 1MiB. Also fix to read only 16KiB of file to pass to analyze, it was set to 16MiB by mistake 😈
Should fix #11969