Skip to content

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 18, 2020

Before:
chrome_2020-05-18_20-30-27

After:
chrome_2020-05-18_20-30-39

@silverwind
Copy link
Member

silverwind commented May 18, 2020

Suggestion (also remove unneccesary float and line-height):

.repository .segment.reactions .select-reaction {
  display: flex;
  align-items: center;
  padding: .5rem;
}

.repository .segment.reactions .ui.label,
.repository .segment.reactions .ui.label.visible {
  padding: .5rem 1rem;
  display: flex;
  align-items: center;
}

.repository .segment.reactions .reaction-count {
  margin-left: .5rem;
}

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 18, 2020

@silverwind Feel free to open new PR with your changes, a bit lost about what exactly you want to add, remove or change.

@silverwind
Copy link
Member

#11496

@bagasme
Copy link
Contributor

bagasme commented May 19, 2020

@CirnoT I don't see any visual differences here

@zeripath
Copy link
Contributor

Closed by #11496

@zeripath zeripath closed this May 19, 2020
@CirnoT CirnoT deleted the add-reaction_middle branch May 19, 2020 12:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants