Patch fomantic-ui to workaround build issue #11244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Better workaround than go-gitea#10653 for fomantic/Fomantic-UI#1356. It does not seem like we're getting a new Fomantic-UI release anytime soon, so this patches it after node_modules installation. Fixes: go-gitea#11243 Fixes: go-gitea#10679
|
I disabled git line ending normalization on the patch because Fomantic-UI's file has CRLF: |
GiteaBot
added
the
lgtm/need 2
silverwind
commented
Apr 29, 2020
silverwind
force-pushed
the
patch-fomantic
branch
from
2c46101 to
8256f58
Compare
|
|
Sorien
reviewed
Apr 29, 2020
Co-Authored-By: Sorien <[email protected]>
6543
approved these changes
Apr 29, 2020
GiteaBot
added
lgtm/need 1
|
CI fail is unrelated, I'm restarting the CI task. |
zeripath
reviewed
Apr 29, 2020
GiteaBot
added
lgtm/done
|
Make lg-tm work |
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Patch fomantic-ui to workaround build issue Better workaround than go-gitea#10653 for fomantic/Fomantic-UI#1356. It does not seem like we're getting a new Fomantic-UI release anytime soon, so this patches it after node_modules installation. Fixes: go-gitea#11243 Fixes: go-gitea#10679 * copy instead of patch * update package-lock.json * Update Makefile Co-Authored-By: Sorien <[email protected]> * Update web_src/fomantic/css.js Co-Authored-By: zeripath <[email protected]> Co-authored-by: Sorien <[email protected]> Co-authored-by: zeripath <[email protected]> Co-authored-by: Lunny Xiao <[email protected]> Co-authored-by: guillep2k <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better workaround than #10653 for fomantic/Fomantic-UI#1356. It does not seem like we're getting a new Fomantic-UI release anytime soon, so this patches it after node_modules installation. Patch source is from here.
Fixes: #11243
Fixes: #10679