Skip to content

Fomantic: Transition: Element is no longer attached to DOM #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silverwind opened this issue Mar 7, 2020 · 7 comments
Closed

Fomantic: Transition: Element is no longer attached to DOM #10653

silverwind opened this issue Mar 7, 2020 · 7 comments
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@silverwind
Copy link
Member

silverwind commented Mar 7, 2020 •
edited
Loading

This is apparently still happening rarely, opening this issue to track it further.

I don't know the exact cause but when it happens, semantic.min.css is missing some CSS rules which in turn breaks a lot of functionality in the UI. More investigation on what exactly is not being built is needed. I suspect a underlying race condition in Fomantic's build process.

Workaround is just to rebuild fomantic (make fomantic) until it produces proper files.
@lunny lunny added type/bug topic/ui Change the appearance of the Gitea UI labels Mar 7, 2020
@zeripath
Copy link
Contributor

zeripath commented Mar 7, 2020

Thanks for looking into this @silverwind

@silverwind
Copy link
Member Author

I reproduced within 6 build cycles:

705K public/fomantic/semantic.min.css
705K public/fomantic/semantic.min.css
705K public/fomantic/semantic.min.css
705K public/fomantic/semantic.min.css
673K public/fomantic/semantic.min.css
705K public/fomantic/semantic.min.css

Checking if I can reproduce in the Fomantic repo itself.

@silverwind
Copy link
Member Author

Also reproducible in the Fomantic repo:

$ while true; do rm -rf dist && npx gulp build &>/dev/null && stat --printf="%s" dist/semantic.min.css | xargs; done
1354924
1354924
1321417
1354924
1354924
1321417
1321417

Bug report coming up soon.

@silverwind
Copy link
Member Author

fomantic/Fomantic-UI#1356

silverwind added a commit to silverwind/gitea that referenced this issue Mar 7, 2020
@silverwind
Workaround fomantic build issue
ea6c93c 
This blows up the fomantic CSS by around 500kB, but I see no other way.

Ref: go-gitea#10653
@silverwind silverwind mentioned this issue Mar 7, 2020
Merged
lafriks pushed a commit that referenced this issue Mar 7, 2020
@silverwind
Workaround fomantic build issue (#10655)
0c2148c 
This blows up the fomantic CSS by around 500kB, but I see no other way.

Ref: #10653
@kaptinlin
Copy link

I have this issue too after install gitea.

Transition: Element is no longer attached to DOM. Unable to animate.  Use silent setting to surpress this warning in production. slide down in <div class=​"menu" tabindex=​"-1">​…​</div>​
error @ semantic.min.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:11
animate @ semantic.min.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:11
initialize @ semantic.min.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:11
(anonymous) @ semantic.min.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:11
each @ jquery.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:1
each @ jquery.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:1
(anonymous) @ semantic.min.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:11
show @ semanticDropdown.js:3641
show @ semanticDropdown.js:603
toggle @ semanticDropdown.js:576
eventOnElement @ semanticDropdown.js:1799
toggle @ semanticDropdown.js:1287
dispatch @ jquery.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:1
(anonymous) @ jquery.js?v=f820ffd1cde10fabc3a8915a0e5b6b1e:1

@silverwind
Copy link
Member Author

@kaptinlin should be resolved in the lastest master build.

@zeripath zeripath mentioned this issue Mar 7, 2020
Closed
7 tasks
@silverwind silverwind mentioned this issue Mar 9, 2020
Closed
4 tasks
@silverwind
Copy link
Member Author

Closing, workaround (#10655) will be removed next Fomantic release.

silverwind added a commit to silverwind/gitea that referenced this issue Apr 29, 2020
@silverwind
Patch fomantic-ui to workaround build issue
f3eb8a6 
Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679
@silverwind silverwind mentioned this issue Apr 29, 2020
Merged
zeripath added a commit that referenced this issue Apr 30, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (#11244)
310699b 
* Patch fomantic-ui to workaround build issue

Better workaround than #10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: #11243
Fixes: #10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@silverwind @Sorien
@zeripath @lunny @guillep2k
Patch fomantic-ui to workaround build issue (go-gitea#11244)
04619d2 
* Patch fomantic-ui to workaround build issue

Better workaround than go-gitea#10653
for fomantic/Fomantic-UI#1356. It does not
seem like we're getting a new Fomantic-UI release anytime soon, so
this patches it after node_modules installation.

Fixes: go-gitea#11243
Fixes: go-gitea#10679

* copy instead of patch

* update package-lock.json

* Update Makefile

Co-Authored-By: Sorien <[email protected]>

* Update web_src/fomantic/css.js

Co-Authored-By: zeripath <[email protected]>

Co-authored-by: Sorien <[email protected]>
Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: guillep2k <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @silverwind @kaptinlin @zeripath