Skip to content

Conversation

zeripath
Copy link
Contributor

Very slight simplification of accessibleRepositoryCondition - remove one of the In queries.

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Mar 29, 2020
@zeripath zeripath added this to the 1.12.0 milestone Mar 29, 2020
@lunny
Copy link
Member

lunny commented Mar 29, 2020

It looks good, but why CI failed.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2020
@zeripath
Copy link
Contributor Author

zeripath commented Mar 29, 2020

I suspect it's unrelated and may be related to the start of summertime in many places?


Nope - continuing the good old De Morgan's law theme...

@lafriks lafriks added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Mar 29, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2020
@zeripath
Copy link
Contributor Author

make lg-tm work

@zeripath zeripath merged commit 209045f into go-gitea:master Mar 29, 2020
@zeripath zeripath deleted the slight-simplification-accessible-repo-subquery branch March 29, 2020 14:31
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants