Skip to content

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676) #10797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2020
Merged

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676) #10797

merged 2 commits into from
Mar 23, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Mar 22, 2020 •
edited
Loading

Backport #10676

Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID

Signed-off-by: Andrew Thornton [email protected]

@zeripath
Fix panic in API pulls when headbranch does not exist (go-gitea#10676)
c0730bf 
Backport go-gitea#10676

* Fix panic in API pulls when headbranch does not exist
* refix other reference to plumbing.ErrReferenceNotFound

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.11.4 milestone Mar 22, 2020
@zeripath zeripath changed the title Fix panic in API pulls when headbranch does not exist (#10676) Convert plumbing.ErrReferenceNotFound to git.ErrNotExist in GetRefCommitID (#10676) Mar 22, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2020
@zeripath
Copy link
Contributor Author

Make lg-tm work

@lafriks
Copy link
Member

lafriks commented Mar 23, 2020 •
edited
Loading

Please force push to trigger drone managed to redeliver webhook from settings

lafriks
lafriks reviewed Mar 23, 2020
View reviewed changes
@lafriks
Copy link
Member

lafriks commented Mar 23, 2020

Make lg-tm work

@lafriks lafriks merged commit 3dabfd4 into go-gitea:release/v1.11 Mar 23, 2020
@zeripath zeripath deleted the backport-10676 branch March 23, 2020 13:11
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.11.4
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @lafriks @lunny @GiteaBot