Makefile: Use hash over which #1069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error |
tboerger
added
the
lgtm/need 2
|
You should rebase I think. |
`hash` is a much faster shell-builtin alternative to `which`.
silverwind
force-pushed
the
hash-over-which
branch
from
e40835b to
c3144ff
Compare
|
Rebased. |
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Feb 26, 2017
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashis a much faster shell-builtin alternative towhich. I checked and it's available even on minimal shells like busybox, so I think it's save to use.As suggested by @tboerger.