Skip to content

Fix potential bugs #10513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 27, 2020
Merged

Fix potential bugs #10513

merged 5 commits into from
Feb 27, 2020

Conversation

6543
Copy link
Member

@6543 6543 commented Feb 27, 2020 •
edited
Loading

potintial bugs ...

  • check if err first before use var
  • use engine if is param
  • remove always true statement

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Feb 27, 2020
@6543 6543 requested a review from zeripath February 27, 2020 21:49
6543
6543 commented Feb 27, 2020
View reviewed changes
@6543 6543 changed the title Use e if it is an option Fix potential bugs Feb 27, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 27, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 27, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@c810d53). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #10513   +/-   ##
=========================================
  Coverage          ?   43.66%           
=========================================
  Files             ?      586           
  Lines             ?    81475           
  Branches          ?        0           
=========================================
  Hits              ?    35576           
  Misses            ?    41486           
  Partials          ?     4413

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c810d53...2be7329. Read the comment docs.

guillep2k
guillep2k approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ones!

@guillep2k guillep2k merged commit e57ac84 into go-gitea:master Feb 27, 2020
@6543 6543 mentioned this pull request Feb 27, 2020
Merged
@6543 6543 deleted the smal-fixes branch February 27, 2020 23:14
@lunny
Copy link
Member

lunny commented Feb 28, 2020

@6543 could you send a backport to v1.11?

6543 added a commit to 6543-forks/gitea that referenced this pull request Feb 28, 2020
@6543
Fix potential bugs (go-gitea#10513)
73c7ca8 
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
@6543 6543 mentioned this pull request Feb 28, 2020
Merged
@6543
Copy link
Member Author

6543 commented Feb 28, 2020

backport: #10518

guillep2k pushed a commit that referenced this pull request Feb 28, 2020
@6543
Fix potential bugs (#10513) (#10518)
11300ee 
* use e if it is an option
* potential nil so check err first
* check err first
* m == nil already checked
@lunny lunny added the backport/done All backports for this PR have been created label Feb 28, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@guillep2k guillep2k guillep2k approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@6543 @codecov-io @lunny @lafriks @zeripath @guillep2k @GiteaBot