Skip to content

Fix wiki raw view on sub path #10002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2020
Merged

Fix wiki raw view on sub path #10002

merged 5 commits into from
Jan 28, 2020

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 26, 2020

Fix #9166

@lunny lunny added this to the 1.12.0 milestone Jan 26, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 26, 2020
@lunny lunny force-pushed the lunny/fix_wiki_raw_sub_path branch from 42e7271 to 0b1de91 Compare January 27, 2020 03:03
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2020
@codecov-io
Copy link

codecov-io commented Jan 27, 2020 •
edited
Loading

Codecov Report

Merging #10002 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10002      +/-   ##
==========================================
+ Coverage   42.26%   42.27%   +0.01%     
==========================================
  Files         610      610              
  Lines       80366    80366              
==========================================
+ Hits        33964    33977      +13     
+ Misses      42227    42214      -13     
  Partials     4175     4175
Impacted Files Coverage Δ
models/repo.go 49.79% <0%> (+0.13%) ⬆️
routers/repo/view.go 39.47% <0%> (+0.87%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️
services/pull/patch.go 69.81% <0%> (+1.88%) ⬆️
models/unit.go 39.5% <0%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb75f3c...7a15e76. Read the comment docs.

@lunny
Copy link
Member Author

lunny commented Jan 27, 2020 •
edited
Loading

Wait I will add more tests.

@zeripath
Copy link
Contributor

make lg-tm work

@zeripath zeripath merged commit c58edc7 into go-gitea:master Jan 28, 2020
@zeripath
Copy link
Contributor

Please send backport

@lunny lunny deleted the lunny/fix_wiki_raw_sub_path branch January 28, 2020 10:04
lunny added a commit to lunny/gitea that referenced this pull request Jan 28, 2020
@lunny
Fix wiki raw view on sub path (go-gitea#10002)
c443bfd 
* Fix wiki raw view on sub path

* Add test for subpath wiki raw file

* Fix bug
@lunny lunny mentioned this pull request Jan 28, 2020
Merged
lunny added a commit to lunny/gitea that referenced this pull request Jan 28, 2020
@lunny
Fix wiki raw view on sub path (go-gitea#10002)
803530d 
* Fix wiki raw view on sub path

* Add test for subpath wiki raw file

* Fix bug
@lunny lunny mentioned this pull request Jan 28, 2020
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jan 28, 2020
zeripath pushed a commit that referenced this pull request Jan 28, 2020
@lunny @zeripath
Fix wiki raw view on sub path (#10002) (#10040)
1e73dd2 
* Fix wiki raw view on sub path

* Add test for subpath wiki raw file

* Fix bug
zeripath added a commit that referenced this pull request Jan 28, 2020
@lunny @zeripath
Fix wiki raw view on sub path (#10002) (#10041)
158b716 
* Fix wiki raw view on sub path

* Add test for subpath wiki raw file

* Fix bug

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

Images in wiki repo (not in root but in subdirectory) respond 404
6 participants
@lunny @codecov-io @zeripath @techknowlogick @guillep2k @GiteaBot