NOT NULL constraints for DB

[ethantkoenig]

A lot of database fields that conceptually should always be populated do not have NOT NULL constraints. For instance, the num_stars, num_forks, num_watches, etc. fields in the repository table do not have NOT NULL constraints. This is problematic, because if those columns have null entries, increment/decrement operations will have no effect.

Is there a reason that these columns don't have NOT NULL constraints?

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[andreynering]

I think we should add NOT NULL where it makes sense.

We just have to make sure all records have values on these columns before migrate. In these cases (num_XXX), just update and set to 0 where it have NULL.

[lunny]

Yes. I think add NOT NULL is a good idea.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.