Pull request 500 error

[bkodre]

• Gitea version: 1.9.4
• Git version: 2.22.0
• Operating system: ubuntu 18.04
• Database :
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

I get 500 error on creating new pull request.
Pre-push file does not exist on gitea server.

Logs:

2019/10/23 14:27:44 routers/repo/pull.go:751:CompareAndPullRequestPost() [E] PushToBaseRepo: Push: exit status 1 - \nThis repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting .git/hooks/pre-push.\n
	error: failed to push some refs to '/data/git/repositories/company/product.git'

[zeripath]

Presumably "company/product.git" is a forked repo - I would take a look at the original base repos git.

[bkodre]

Nope this repo is not a fork. I get this error when i try to create pull request to merge changes from feauture branch to master branch on original repo in gitea.

[zeripath]

So it's a very odd error message I think there must be something in your git config somewhere that is adding git hooks to temporary repositories.

[bkodre]

Config file in this repo contains:

[core]
repositoryformatversion = 0
filemode = false
bare = true
symlinks = false
ignorecase = false

[zeripath]

It's won't be that repo that has the weird config. It's the newly created temporary repo that you don't see. We almost always create a temporary repo with shared object data to prevent the temp repo from destroying the real repo.

Something is telling git to create repositories with git-lfs hooks when git-lfs is not installed.

[bkodre]

Content of app.ini on our gitea server:

APP_NAME = Company Gitea
RUN_MODE = prod
RUN_USER = user

[repository]
ROOT = /data/git/repositories

[repository.local]
LOCAL_COPY_PATH = /data/gitea/tmp/local-repo

[repository.upload]
TEMP_PATH = /data/gitea/uploads

[server]
APP_DATA_PATH    = /data/gitea
SSH_DOMAIN       = https://gitea.company.com
HTTP_PORT        = 3000
#PROTOCOL	 = https
#REDIRECT_OTHER_PORT = true
#PORT_TO_REDIRECT = 3000
ROOT_URL         = https://gitea.company.com/
DISABLE_SSH      = false
SSH_PORT         = 22
LFS_START_SERVER = true
LFS_CONTENT_PATH = /data/git/lfs
LFS_JWT_SECRET   = LFS_JWT_SECRET
DOMAIN           = https://gitea.company.com
OFFLINE_MODE     = false

[database]
PATH     = /data/gitea/gitea.db
DB_TYPE  = mysql
HOST     = db:3306
NAME     = NAME
USER     = USER
PASSWD   = PASSWD
SSL_MODE = disable
CHARSET  = utf8
LOG_SQL  = false

[indexer]
ISSUE_INDEXER_PATH = /data/gitea/indexers/issues.bleve

[session]
PROVIDER_CONFIG = /data/gitea/sessions
PROVIDER        = file

[picture]
AVATAR_UPLOAD_PATH            = /data/gitea/avatars
REPOSITORY_AVATAR_UPLOAD_PATH = /data/gitea/repo-avatars
DISABLE_GRAVATAR              = false
ENABLE_FEDERATED_AVATAR       = true

[attachment]
PATH = /data/gitea/attachments

[log]
ROOT_PATH = /data/gitea/log
MODE      = file
LEVEL     = info

[security]
INSTALL_LOCK   = true
SECRET_KEY     = SECRET_KEY
INTERNAL_TOKEN = INTERNAL_TOKEN

[service]
DISABLE_REGISTRATION              = false
REQUIRE_SIGNIN_VIEW               = false
REGISTER_EMAIL_CONFIRM            = false
ENABLE_NOTIFY_MAIL                = false
ALLOW_ONLY_EXTERNAL_REGISTRATION  = false
ENABLE_CAPTCHA                    = false
DEFAULT_KEEP_EMAIL_PRIVATE        = false
DEFAULT_ALLOW_CREATE_ORGANIZATION = true
DEFAULT_ENABLE_TIMETRACKING       = true
NO_REPLY_ADDRESS                  = noreply.example.org

[oauth2]
JWT_SECRET = JWT_SECRET

[lunny]

Since you enabled LFS, gitea will check if your have installed git lfs when start. But why it reported error when running.

[bkodre]

Are there some other config files that can affect this repo?

[zeripath]

It's not app.ini you need to look at.

This is coming from git. You need to look at git config for your user and the server.

[bkodre]

So global git config could do this?

[bkodre]

Do we need to have git lfs client instaled on gitea server?

[zeripath]

You shouldn't need git-lfs but if you have previously installed and removed git-lfs you need to ensure that it's been removed completely.

I would just try creating a git repo on the server and see if that gets lfs hooks added - if it does you haven't removed git-lfs completely

[bkodre]

No i did't have git lfs client installed.

[bkodre]

I created new repo and two hooks are created.

pre-receive:

#!/usr/bin/env bash
data=$(cat)
exitcodes=""
hookname=$(basename $0)
GIT_DIR=${GIT_DIR:-$(dirname $0)}

for hook in ${GIT_DIR}/hooks/${hookname}.d/*; do
test -x "${hook}" || continue
echo "${data}" | "${hook}"
exitcodes="${exitcodes} $?"
done

for i in ${exitcodes}; do
[ ${i} -eq 0 ] || exit ${i}
done

post-receive:

 #!/usr/bin/env bash
 data=$(cat)
 exitcodes=""
 hookname=$(basename $0)
 GIT_DIR=${GIT_DIR:-$(dirname $0)}

 for hook in ${GIT_DIR}/hooks/${hookname}.d/*; do
 test -x "${hook}" || continue
 echo "${data}" | "${hook}"
 exitcodes="${exitcodes} $?"
 done

 for i in ${exitcodes}; do
 [ ${i} -eq 0 ] || exit ${i}
 done