Skip to content

Pages, but as subdir rather than subdomain #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewgdunn opened this issue Feb 22, 2019 · 3 comments
Closed

Pages, but as subdir rather than subdomain #6163

andrewgdunn opened this issue Feb 22, 2019 · 3 comments

Comments

@andrewgdunn
Copy link

andrewgdunn commented Feb 22, 2019

Pages has been proposed in several other issues, to enumerate some:

However there is an assumption that you must use subdomains as this is how github/gitlab have implemented them. Some are suggesting bundling of caddy (e.g. #1721) but this is making a choice for people that is uncomfortable (e.g. I enjoy running a simple go binary behind nginx for tls termination, I don't particularly want nginx->caddy->gitea or to learn/use caddy for just gitea)

Rightfully proposed by @techknowlogick in #302, if you're going to do subdomain pages you might as well work that through the CI route. However many users are going to be interested in static page hosting without having a CI system.

It could be possible to run these pages as subdirectories, maybe with a prefix of ~/ of some kind where ~/organization provides a static page for the organization and ~/organization/repo does the same for repo (switch organization for user), with some complexity in access control (e.g. don't show static pages to users who have not logged in, if that's the intent).

So, this can me marked dupe and closed, but I'll offer one twist:

This is an interesting feature and we'd be willing to fund it directly. We cannot bounty-source and we cannot easily donate to the project but we can contract directly with a developer(s) who want to take this work on as long as you propose a plan that upstream is willing to bite on. It would be the lowest risk for us to work with proven contributors or maintainers of this project.

@lunny
Copy link
Member

lunny commented Feb 23, 2019

There are some security reasons to be consider when using subdir than subdomain.

@bricewge bricewge mentioned this issue Mar 2, 2019
@stale
Copy link

stale bot commented Apr 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Apr 24, 2019
@lunny lunny closed this as completed Apr 24, 2019
@sblisesivdin
Copy link

I think even a static page website thing is not necessary. Wiki feature can be used to built sites with subdir. The thing is people want to host documentation and project related websites with this. No need to repeat the GitHub or GitLab on this feature.

@go-gitea go-gitea locked and limited conversation to collaborators May 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants