Better presentation for files attached to issues

[ctrlaltca]

• Gitea version (or commit ref): 1.7.0
• Git version: 2.14.5
• Operating system: Slackware64 14.2
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant (the demo doesn't allow non-image uploads)
• Log gist:

Description

Looking at the view rendering issue attachments, it seems that only images have a special handling.
If you attach files of other types (eg. pdf, txt, odt, ..) an icon with a tooltip containing the file name is rendered.
If an issue contains more than one attachment, it's quite hard to look for a specific attachment on desktop, and impossible on mobile without downloading them all.
It would be nice to have at least the file name printed (alone or alongside the icon), or even better to have an icon like the one already used for newly uploaded files

Screenshots

The screenshot is from an issue containing 2 pdf and 3 odt attachments. There's no way to discriminate between the files:

The icon used for newly uploaded files is way nicer:

[silverwind]

Kind of related: I'd like to see the image preview in the footer removed for image attachments that are already displayed inline.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[Mikanoshi]

Also... why is it so huge? :D Changed style to 24px, looks just fine.

[renevdzee]

What about making it look the same as release-attachments? like this:

This is what I changed to make it look like this (v1.9.3): patch.txt
I edited the templates in my custom/templates/ folder. I had to add a number of style-keywords because I didn't want to change any stylesheets (I don't know how to do this better in semantic-ui)

(would also fix issue #6501)

[guillep2k]

@renevdzee I would really love that. And I've been wishing to hide the pictures already shown in the contents block (but that's more difficult to implement.... perhaps if the HTML parser adds a custom attribute to the <img> files? Can that be targeted somehow with CSS rules and match by URL?).

[guillep2k]

@renevdzee care to make a PR?

[renevdzee]

@guillep2k about the PR, I think I shouldn't. But feel free to take any element from my patch to create a better implementation than I did. Maybe someone with more html/css knowledge can take a look at it.