Autolinked URLs: fragment components not included in generated link #5844
Labels
Comments
|
Which gitea version are you using? |
|
Gitea version 1.6.3 or 1.6.4. |
|
The issue exist also in version 1.7.1. |
|
@veita could you give an example of a Gitea path that doesn't work on try.gitea.io . It would hello to completely identify and fix this issue |
|
Just put the link given in the issue description into a |
mrsdizzie
added a commit
to mrsdizzie/gitea
that referenced
this issue
Mar 7, 2019
Rather than maintaining a complicated regex to match URLs for autolinking, gitea can use this existing go library that takes care of the matching with very little code change to gitea itself. After spending a while trying to find the perfect regex for all cases this library still works better as it is more flexible than a single regex ever will be. This will also fix the following issues: go-gitea#5844 go-gitea#3095 go-gitea#3381 This passes all our current tests and I've added new ones mentioned in those issues as well.
techknowlogick
pushed a commit
that referenced
this issue
Mar 7, 2019
* Replace linkRegex with xurls library Rather than maintaining a complicated regex to match URLs for autolinking, gitea can use this existing go library that takes care of the matching with very little code change to gitea itself. After spending a while trying to find the perfect regex for all cases this library still works better as it is more flexible than a single regex ever will be. This will also fix the following issues: #5844 #3095 #3381 This passes all our current tests and I've added new ones mentioned in those issues as well. * Use xurls.StrictMatchingScheme instead of xurls.Strict This is much faster and we only care about https? links to preserve existing behavior.
|
Closing per merged PR |
|
I can confirm that the issue is fixed in Gitea 1.8.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Some autolinked URLs are not linked correctly. E.g.
is rendered without the fragment component. The same URL works on GitHub:
https://github.com/go-gitea/gitea/?p=aaa/bbb.html#ccc-ddd
The text was updated successfully, but these errors were encountered: