-
-
Notifications
You must be signed in to change notification settings - Fork 6k
Closed
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.
Description
After some more research about how GitHub handles autolinking, I wound up finding the proper GFM spec. One of the goals of #3354 is that of porting over functionality, which was previously provided by JavaScript, into Go, which is why I do not intend to include this as part of the PR, seeing as that is already quite big. However, once it is merged, it might be good to replace the linkProcessor
in modules/markup/html.go
with a proper processor following the GFM specification - which should hopefully solve once and for all all issues regarding autolinking not working.
This would also fix #3095.
cc/ @ypnos
ypnos, zmnv and lafriks
Metadata
Metadata
Assignees
Labels
issue/confirmedIssue has been reviewed and confirmed to be present or accepted to be implementedIssue has been reviewed and confirmed to be present or accepted to be implementedtype/refactoringExisting code has been cleaned up. There should be no new functionality.Existing code has been cleaned up. There should be no new functionality.