Skip to content

Extra slash in the redirection when redirecting to HTTPS when using Let's Encrypt #5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
1 of 7 tasks
gregkare opened this issue Dec 12, 2018 · 0 comments · Fixed by #5537
Closed
1 of 7 tasks

Extra slash in the redirection when redirecting to HTTPS when using Let's Encrypt #5536

gregkare opened this issue Dec 12, 2018 · 0 comments · Fixed by #5537
Labels
type/bug
Milestone
1.6.2

Comments

@gregkare
Copy link
Contributor

  • Gitea version (or commit ref): master
  • Git version: not relevant
  • Operating system: macOS, Linux
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

When Let's Encrypt is enabled, the redirections from HTTP to HTTPS add an extra slash at the end of the URL. I have identified the problem and am going to push a PR.

$ curl 0.0.0.0:3001/
<a href="https://gitea.example.com:3000//">Found</a>.

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

$ curl 0.0.0.0:3001/test
<a href="https://gitea.example.com:3000//test">Found</a>.
gregkare added a commit to 67P/gitea that referenced this issue Dec 12, 2018
@gregkare
Remove a double slash in the HTTPS redirection when Let's Encrypt is …
6bd01f9 
…enabled

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes go-gitea#5536
@gregkare gregkare mentioned this issue Dec 12, 2018
Merged
lafriks pushed a commit that referenced this issue Dec 12, 2018
@gregkare @lafriks
Remove a double slash in the HTTPS redirection when Let's Encrypt is …
ebef3ef 
…enabled (#5537)

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes #5536
@lafriks lafriks added this to the 1.6.2 milestone Dec 12, 2018
gregkare added a commit to 67P/gitea that referenced this issue Dec 13, 2018
@gregkare
Backport go-gitea#5537 Remove a double slash in the HTTPS redirect wi…
2a92272 
…th Let's Encrypt

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes go-gitea#5536
@gregkare gregkare mentioned this issue Dec 13, 2018
Merged
techknowlogick pushed a commit that referenced this issue Dec 13, 2018
@gregkare @techknowlogick
Backport #5537 Remove a double slash in the HTTPS redirect with Let's…
200b974 
… Encrypt (#5539)

Before:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000//">Found</a>.

After:

$ curl 0.0.0.0:3001
<a href="https://gitea.example.com:3000/">Found</a>.

Fixes #5536
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.6.2
Development

Successfully merging a pull request may close this issue.

Remove a double slash in the HTTPS redirection when Let's Encrypt is enabled 67P/gitea
2 participants
@gregkare @lafriks