[BUG] Due date format issue

[mmarif4u]

• Gitea version (or commit ref): 5fc0a12

• Can you reproduce the bug at https://try.gitea.io:

  • Yes
  • No
  • Not relevant

I guess the following image would explain the issue better.

[eloyekunle]

On which page do you currently experience this issue?

[lafriks]

It is on issue page

[kolaente]

We already have multiple issues regarding this, should we use some library to handle date formatting?

[kanozec]

But I saw the response of "https://try.gitea.io/api/v1/repos/{userName}/{repoName}/issues/1/deadline" in the chrome console is 401

And the request payload is {due_date: "2017-02-17T00:00:00.000Z"}

This issue seems not caused by error formating

[kolaente]

@kanocz anything in the logs?

[kanozec]

I only have the browser console log.

Actually, I have some trouble to run gitea on my local.

[kolaente]

@kanocz What was the response?

Also, if you have problems running Gitea locally, feel free to ask in our Discord server or the forum.

[kanozec]

[Macaron] 2018-10-31 21:10:17: Completed POST /api/v1/repos/Kee1234/gggg/issues/1/deadline 401 Unauthorized in 8.82763ms

I got this on my local environment.

The response was 401. Since the client ajax call got the 401 error, the js function setDeadline() handle the error in the same way. So it shows the "The due date is invalid or out of range. Please use the format 'yyyy-mm-dd' " on the page.

[jamesa]

This also happens in the Swagger dashboard for the same request.

[kolaente]

Looks like this was broken by #4840 (among other things)

[kanozec]

@kolaente Yes, I trace the code and make some experiments. I found that

ctx.Data["IsApiToken"] = true

does not be executed while checking user is signed.

So

func reqToken() macaron.Handler {
	return func(ctx *context.Context) {
		for  key := range ctx.Data{
			fmt.Printf("Key: %s |Value: %v\n", key, ctx.Data[key])
		}
		if true != ctx.Data["IsApiToken"] {
			ctx.Error(401)
			return
		}
	}
}

always gets 401 error.

#5249 shows the solution to fix this bug

[kolaente]

I've opened #5249 to fix this and other issues.