Webhook for "Issue Comment" contains no secret #4732
Description
- Gitea version (or commit ref): 1.5
- Git version: 2.1.4
- Operating system: Raspbian
- Database (use
[x]):- PostgreSQL
- MySQL (MariaDB)
- MSSQL
- SQLite
- Can you reproduce the bug at https://try.gitea.io:
- Yes (provide example URL)
- No
- Not relevant
- Log gist:
Description
When setting up webhooks in gitea, I expect that every hook uses the secret one chooses.
But for issue_comment there is no secret field in the json which is send out.
The send json:
{
"action": "created",
"issue": {
"id": 23,
"url": "<url>",
"number": 11,
"user": {
// User Object
},
"title": "123",
"body": "",
"labels": [],
"milestone": null,
"assignee": null,
"assignees": null,
"state": "open",
"comments": 0,
"created_at": "2018-08-13T08:39:29Z",
"updated_at": "2018-08-16T16:44:36Z",
"closed_at": null,
"due_date": null,
"pull_request": null
},
"comment": {
"id": 42,
"html_url": "<html_url>",
"pull_request_url": "",
"issue_url": "<issue_url>",
"user": {
// User object
},
"body": "No secret?",
"created_at": "2018-08-16T16:44:36Z",
"updated_at": "2018-08-16T16:44:36Z"
},
"repository": {
"id": 6,
"owner": {
// User object
},
"name": "hook-test",
"full_name": "mh/hook-test",
"description": "",
"empty": false,
"private": true,
"fork": false,
"parent": null,
"mirror": false,
"size": 128,
"html_url": "<html_url>",
"ssh_url": "<ssh_url>",
"clone_url": "<clone_url>",
"website": "",
"stars_count": 0,
"forks_count": 0,
"watchers_count": 1,
"open_issues_count": 7,
"default_branch": "master",
"created_at": "2018-08-12T09:50:19Z",
"updated_at": "2018-08-13T10:59:50Z",
"permissions": {
"admin": true,
"push": true,
"pull": true
}
},
"sender": {
// User object
}
}To reproduce:
- Create a webhook in gitea, choose "Custom Events...." -> "Issue Comment"
- Add a comment to a arbitrary issue in that repo
- Edit the webhook and look at "Recent Deliveries"