Skip to content

Many links broken #4081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 7 tasks
ghost opened this issue May 30, 2018 · 3 comments · Fixed by #4082
Closed
1 of 7 tasks

Many links broken #4081

ghost opened this issue May 30, 2018 · 3 comments · Fixed by #4082
Labels
Milestone

Comments

@ghost
Copy link

ghost commented May 30, 2018

Description

The link should be
https://try.gitea.io/yasuokav/link-test/issues/1
instead of
https://try.gitea.io/yasuokav/link-test/issues/yasuokav/link-test/issues/1

Please check the links above for more details.

I think this issue because of #4058 @JonasFranzDEV

Screenshots

N/A

@sapk
Copy link
Member

sapk commented May 30, 2018

It should be related to the remove of leading '/' when base isn't absolute (with a scheme). This test should be change to add a check if base start with a '/' to keep it.
As this error is related to a suggested solution of mine ^^.

@lunny
Copy link
Member

lunny commented May 30, 2018

@JonasFranzDEV And I'm afraid release/v1.4 is also affected.

@sapk
Copy link
Member

sapk commented May 30, 2018

@lunny fix is ready. I will backport it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants