Fix #4081 Check for leading / in base before removing it (#4082)

Author: sapk

modules/util/util.go

@@ -72,8 +72,8 @@ func URLJoin(base string, elems ...string) string {
 		return ""
 	}
 	joinedURL := baseURL.ResolveReference(argURL).String()
-	if !baseURL.IsAbs() {
-		return joinedURL[1:] // Removing leading '/'
+	if !baseURL.IsAbs() && !strings.HasPrefix(base, "/") {
+		return joinedURL[1:] // Removing leading '/' if needed
 	}
 	return joinedURL
 }

modules/util/util_test.go

@@ -32,6 +32,12 @@ func TestURLJoin(t *testing.T) {
 			"a/", "b/c/", "/../d/"),
 		newTest("https://try.gitea.io/a/b/c#d",
 			"https://try.gitea.io", "a/b", "c#d"),
+		newTest("/a/b/d",
+			"/a/", "b/c/", "/../d/"),
+		newTest("/a/b/c",
+			"/a", "b/c/"),
+		newTest("/a/b/c#hash",
+			"/a", "b/c#hash"),
 	} {
 		assert.Equal(t, test.Expected, URLJoin(test.Base, test.Elements...))
 	}