multipart-* temp files not be clean when call api: releases/id/assets

[wbob126]

Description

I have nightly-build script in ci, that do publish artifact-files as assets for releases.

the bash script like this:

curl --request POST --url "${GiteaBaseUrl}/repos/${GiteaRepo}/releases/$id/assets?name=$name" --header 'accept: application/json' --header 'Content-Type: multipart/form-data' --header "authorization: Bearer ${GiteaAuthToken}" --form "attachment=@$upfile"

Each artifact about 1.2GB size.

Whatever, the work completed, but files name's multipart-* are not be clean in the %temp% path.

Should delete files in %temp%
multipart-150005186
multipart-592395740
...

Another issue

I set [server].APP_TEMP_PATH to other path, but multipart-* always created in %temp% path.

And I found that:

ref: #19595

Gitea Version

1.25.2

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Windows

How are you running Gitea?

gitea-1.25.2-gogit-windows-4.0-amd64.exe as windows server

Database

MariaDB

[wxiaoguang]

Hmm, it is a regression.

The Golang HTTP framework is quite fragile when parsing forms .....

-> Make Golang correctly delete temp files during uploading #36128

Now a test is added to make sure the temp files will always be deleted correctly