Tests fail

[hramrach]

Description

Tests fail on current git

Gitea Version

current

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

https://gist.github.com/hramrach/fb6283777726775bc5459c7bfac27011

Screenshots

No response

Git Version

No response

Operating System

Linux, openSUSE Leap 16.0

How are you running Gitea?

not at all

Database

None

[wxiaoguang]

   CustomPath: /etc/gitea
   ConfigFile: /etc/gitea/conf/app.ini

No, it can't be right. Check why your test uses that incorrect paths.

[hramrach]

Why would it?

ls /etc/gitea/conf/app.ini
ls: cannot access '/etc/gitea/conf/app.ini': No such file or directory

[wxiaoguang]

Why would it?

ls /etc/gitea/conf/app.ini ls: cannot access '/etc/gitea/conf/app.ini': No such file or directory

I don't know. Maybe you have incorrect environment variables, etc.

[hramrach]

What environment variables?

I did not get out of my way to set environment for gitea.

Also using obfuscation like environment variables sure makes debugging a lot of fun.

[wxiaoguang]

TBH I don't know what happens on your side.

Some environment variables do affect Gitea's behavior, even if in the tests. And none of the environments are expected to exist on a normal system.

Anyway, just a guess, I don't know your OS environment.

You can try to start a container or VM to have a clean environment and try, then even if your host has any strange configuration, the tests won't be affected, and then you can try to figure what's wrong on your host.

[hramrach]

Perhaps this would be the environment in question:

GITEA_CUSTOM=/etc/gitea

And perhaps installing gitea sets this which in turn breaks tests.

[wxiaoguang]

And perhaps installing gitea sets this which in turn breaks tests.

No, Gitea won't set it system-wide. It is only set by users by themselves manually (and IIRC no document says to set it system-wide)

[hramrach]

I definitely did not set it manually.

In any case if it breaks tests they should unset it.

[wxiaoguang]

I definitely did not set it manually.

If you think it is caused by code, please show the proof of related code.

Actually, no program can affected system-wide environment variables. An env var set by a program will disappear after the program exits.

[hramrach]

It's probably some misguided packager setting it in the OS package.

In any case, the test should unset it if it breaks it.

[wxiaoguang]

In any case, the test should unset it if it breaks it.

If your disk runs out of space, should the test open an online shop and buy a disk for your OS?