SSH signing key path will be displayed in the pull request UI

[lunny]

Description

related to #34341

After SSH signing key enabled, the KeyID now actually a path which will be displayed in the UI.

Gitea Version

main

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

local

Database

None

[lunny]

Maybe it should be displayed as a fingerprint which could be calculated with CalcFingerprint

[ChristopherHX]

I missed this User interface glitch entirely.

For my own understanding if I would look into this later, this is the path to the fault

• gitea/routers/web/repo/issue_view.go

  Line 497 in e19d0e4

  ctx.Data["SigningKey"] = key

• gitea/routers/web/repo/issue_view.go

  Line 434 in e19d0e4

  ctx.HTML(http.StatusOK, tplIssueView)

• gitea/templates/repo/view.tmpl

  Line 24 in e19d0e4

  {{template "repo/view_content" .}}

• gitea/templates/repo/issue/view_content.tmpl

  Line 71 in e19d0e4

  {{template "repo/issue/view_content/pull_merge_box".}}

• gitea/templates/repo/issue/view_content/pull_merge_box.tmpl

  Line 191 in e19d0e4

  {{ctx.Locale.Tr "repo.signing.will_sign" .SigningKey}}

I also see an additional bug that the SigningKey that is now a structure and is used in the template as a string, so you see a object printed here even for gpg... Where the dynamic templates bit me.

[ChristopherHX]

Created a draft fix in #35381, until validated by myself.