regression: relative URL paths in .gitmodules no longer produce correct submodule links

[AdamMajer]

Description

Relative paths in url= elements of .gitmodules used to work with 1.23.7 but now fail to work with 1.24.2 and latest demo. For example,

https://demo.gitea.com/gnuman/rel_submodule_test

The format in .gitmodules is url=../../org/repo instead of url=https://demo.gitea.com/org/repo. The relative path allows one to move repositories to different instance and the checkout will continues to work.

Gitea Version

1.24.2

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Self-hosted

Database

PostgreSQL

[wxiaoguang]

Related to add submodule diff links (#33097)

Then it's unable to generate "CommitWebLink" for such "relative path" case.

---

Maybe we can just keep the relative path

[wxiaoguang]

I think this one will fix? Make submodule link work with relative path #35034

And added new tests

[AdamMajer]

It seems it's still broken in the case of ../docs relative path. So same organization but different repository.

[wxiaoguang]

Hmm, the complete is Improve submodule relative path handling #35056 , could you try that fix?

[AdamMajer]

I can confirm that the improved hadling fixes all these problems that I can see. Relative and absolute submodules work well. Thanks!

[wxiaoguang]

And it also makes the submodules that in a sub-directory work, I think that doesn't work in 1.23 😆