Skip to content

Rocky Linux 9 (Fedora 34) cannot recognize the signature added by Gitea #33296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ExplodingDragon opened this issue Jan 16, 2025 · 2 comments · Fixed by #33745
Closed

Rocky Linux 9 (Fedora 34) cannot recognize the signature added by Gitea #33296

ExplodingDragon opened this issue Jan 16, 2025 · 2 comments · Fixed by #33745
Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Milestone
1.23.5

Comments

@ExplodingDragon
Copy link
Contributor

ExplodingDragon commented Jan 16, 2025 •
edited
Loading

Due to ProtonMail/go-crypto#208, RPM versions < 4.17 cannot recognize signature information generated by ProtonMail/go-crypto. (see ProtonMail/go-crypto#263)

There is no need to consider fixing this issue until a better solution is available; this issue is only for archiving purposes.

Affected versions : all versions after a8e7cae.
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jan 16, 2025 •
edited
Loading

The ProtonMail/go-crypto 1.1.x is required by go-git 5.13

And yes, according to ProtonMail/go-crypto#263, it is a regression in go-crypto 1.1 ..... I guess it should be fixed by upstream, either revert to the old behavior, or introduce an option

ps: Gitea 1.23.x is also affected because go-git there was also upgraded to 5.13 to fix security issues (#33133 in 1.23)

@wxiaoguang wxiaoguang added the type/upstream This is an issue in one of Gitea's dependencies and should be reported there label Jan 16, 2025
@wxiaoguang wxiaoguang mentioned this issue Jan 25, 2025
Open
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 27, 2025 •
edited by lunny
Loading

Upstream has merged the fix: Make Issuer Key ID signature subpacket non-critical ProtonMail/go-crypto#266

@lunny lunny mentioned this issue Feb 27, 2025
Merged
@lunny lunny added this to the 1.23.5 milestone Feb 27, 2025
wxiaoguang added a commit that referenced this issue Feb 28, 2025
@lunny @wxiaoguang
upgrade go-crypto from 1.1.5 to 1.1.6 (#33745)
ae4a3d7 
Fix #33296

---------

Co-authored-by: wxiaoguang <[email protected]>
lunny added a commit to lunny/gitea that referenced this issue Feb 28, 2025
@lunny @wxiaoguang
upgrade go-crypto from 1.1.5 to 1.1.6 (go-gitea#33745)
579e138 
Fix go-gitea#33296

---------

Co-authored-by: wxiaoguang <[email protected]>
@lunny lunny mentioned this issue Feb 28, 2025
Merged
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug type/upstream This is an issue in one of Gitea's dependencies and should be reported there
Projects
None yet
Milestone
1.23.5
Development

Successfully merging a pull request may close this issue.

upgrade go-crypto from 1.1.5 to 1.1.6 lunny/gitea
3 participants
@lunny @wxiaoguang @ExplodingDragon