Updating mirror settings of a repository could cause it to lose the token for mirroring

[wolfogre]

Description

Reproduction steps:

1. Mirror a private repo from GitHub with a token

2. Sync mirror manually and check admin system notices to make sure everything is fine now.

3. Update the "Mirror Interval", don't touch "Authorization".

4. Sync mirror manually and check admin system notices again.

The error log looks like:

Failed to update mirror repository '/var/lib/gitea/data/gitea-repositories/root/test_private_repo.git': fatal: could not read Username for 'https://github.com': terminal prompts disabled

Gitea Version

v1.21.10

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Binary.

Database

PostgreSQL

[yp05327]

similar to #29904
some options should be handled when edit these settings.

[xyziven]

At step 3, what happens if touch "Authorization"? Looks like only username/password is allowed here for mirror settings, while github requires access token.

[lunny]

At step 3, what happens if touch "Authorization"? Looks like only username/password is allowed here for mirror settings, while github requires access token.

Then the token will be filled into password and username will a generated name. I think this place needs a refactor in future.