Unable to select all available repositories when linking package to repository

[tiredofit]

Description

I am in the process of migrating my images from Docker Hub to my own Gitea Registry, yet am having problems with linking the package to the repository. I have over 100 repositories and when I am presented with the list, it simply shows the most recent 29 repositories.

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

n/a

Operating System

Arch

How are you running Gitea?

Docker - Custom Image based on Alpine 3.18

Database

PostgreSQL

[lunny]

All the 100 repositories are owned by the same owner as the packages?

[tiredofit]

Yes, that is correct. All packages and repositories are a part of an organization to which I am the sole member.

[mopinon]

I have the same problem, I have 66 repositories in my organization, but I get only 30 repositories in the drop-down list. It's because of pagination.
DefaultPagingNum = 30

Stacktrace

gitea/routers/web/user/package.go

Lines 356 to 373 in 1fd7e3d

	func PackageSettings(ctx *context.Context) {
	pd := ctx.Package.Descriptor
	shared_user.RenderUserHeader(ctx)
	ctx.Data["Title"] = pd.Package.Name
	ctx.Data["IsPackagesPage"] = true
	ctx.Data["PackageDescriptor"] = pd
	repos, _, _ := repo_model.GetUserRepositories(&repo_model.SearchRepoOptions{
	Actor: pd.Owner,
	Private: true,
	})
	ctx.Data["Repos"] = repos
	ctx.Data["CanWritePackages"] = ctx.Package.AccessMode >= perm.AccessModeWrite || ctx.IsUserSiteAdmin()
	ctx.HTML(http.StatusOK, tplPackagesSettings)
	}

gitea/models/repo/repo_list.go

Lines 704 to 732 in 1fd7e3d

	func GetUserRepositories(opts *SearchRepoOptions) (RepositoryList, int64, error) {
	if len(opts.OrderBy) == 0 {
	opts.OrderBy = "updated_unix DESC"
	}
	cond := builder.NewCond()
	if opts.Actor == nil {
	return nil, 0, util.NewInvalidArgumentErrorf("GetUserRepositories: Actor is needed but not given")
	}
	cond = cond.And(builder.Eq{"owner_id": opts.Actor.ID})
	if !opts.Private {
	cond = cond.And(builder.Eq{"is_private": false})
	}
	if opts.LowerNames != nil && len(opts.LowerNames) > 0 {
	cond = cond.And(builder.In("lower_name", opts.LowerNames))
	}
	sess := db.GetEngine(db.DefaultContext)
	count, err := sess.Where(cond).Count(new(Repository))
	if err != nil {
	return nil, 0, fmt.Errorf("Count: %w", err)
	}
	sess = sess.Where(cond).OrderBy(opts.OrderBy.String())
	repos := make(RepositoryList, 0, opts.PageSize)
	return repos, count, db.SetSessionPagination(sess, opts).Find(&repos)
	}

gitea/models/db/list.go

Lines 35 to 39 in 1fd7e3d

	func SetSessionPagination(sess Engine, p Paginator) *xorm.Session {
	skip, take := p.GetSkipTake()
	return sess.Limit(take, skip)
	}

gitea/models/db/list.go

Lines 58 to 61 in 1fd7e3d

	func (opts *ListOptions) GetSkipTake() (skip, take int) {
	opts.SetDefaultValues()
	return (opts.Page - 1) * opts.PageSize, opts.PageSize
	}

gitea/models/db/list.go

Lines 76 to 86 in 1fd7e3d

	func (opts *ListOptions) SetDefaultValues() {
	if opts.PageSize <= 0 {
	opts.PageSize = setting.API.DefaultPagingNum
	}
	if opts.PageSize > setting.API.MaxResponseItems {
	opts.PageSize = setting.API.MaxResponseItems
	}
	if opts.Page <= 0 {
	opts.Page = 1
	}
	}

gitea/modules/setting/api.go

Lines 14 to 28 in 1fd7e3d

	var API = struct {
	EnableSwagger bool
	SwaggerURL string
	MaxResponseItems int
	DefaultPagingNum int
	DefaultGitTreesPerPage int
	DefaultMaxBlobSize int64
	}{
	EnableSwagger: true,
	SwaggerURL: "",
	MaxResponseItems: 50,
	DefaultPagingNum: 30,
	DefaultGitTreesPerPage: 1000,
	DefaultMaxBlobSize: 10485760,
	}

[mopinon]

I can fix this problem if one of the members describes the best way to solve it.

[lunny]

How many repositories should be displayed in the list? Maybe we need a dropdown with search box.

[mopinon]

all repositories and search bar

ref github

Screen

[lunny]

I think Github only show 50 items.

[mopinon]

52 out of 52, I won't test until 100)
Pagination will not be needed here if you get only id and name from the database
Or am I wrong?

Screen

[andyhan]

why not allow user to input the whole repository name not only just select one?

[lunny]

52 out of 52, I won't test until 100) Pagination will not be needed here if you get only id and name from the database Or am I wrong?
Screen

search box is necessary here because the user may have over 1000 repositories with admin permissions

[khayo]

in version 1.22.0 this still a problem