Skip to content

Can't rename/remove binary(image, etc) file via webui #24722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artem-check opened this issue May 15, 2023 · 6 comments
Open

Can't rename/remove binary(image, etc) file via webui #24722

artem-check opened this issue May 15, 2023 · 6 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@artem-check
Copy link

Description

"Binary files cannot be edited in the web interface" - edit button is unavailable, there is a hint on it.

And it is also impossible to rename or move the image file.

There is no other way in the Gitea web interface to rename or move a file. This is a bug.

I completely replicated this behavior on try.gitea.io

Gitea Version

1.19.3

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

Debian

How are you running Gitea?

Selfhosted on Debian

Database

SQLite

@silverwind
Copy link
Member

silverwind commented May 15, 2023

Rename can be allowed. Image editing, only via paste of new image, I suppose, and it would be limited to PNG I think, as browser APIs don't really support pasting other formats. Thought a input[type=file] may work for other types.

@artem-check
Copy link
Author

Hi! Thanks! How to allow editing?

1 similar comment
@artem-check
Copy link
Author

Hi! Thanks! How to allow editing?

@silverwind
Copy link
Member

I meant it needs to be implemented, not possible currently.

@lunny lunny added type/proposal The new feature has not been accepted yet but needs to be discussed first. and removed type/bug labels May 16, 2023
@artem-check
Copy link
Author

How to implement it? Can you advise where to start?

@silverwind
Copy link
Member

silverwind commented May 26, 2023

Enabling the edit button in the templates when the content-type of the file is image/* would be the first step. Then you need to modify the template code so the rename UI and commit UI are present and working. Finally, add <input type="file"> in place of the editor that shows for text files.

@wxiaoguang wxiaoguang changed the title Can't rename/remove image file via webui Can't rename/remove binary(image, etc) file via webui Apr 15, 2024
@lunny lunny added this to the 1.25.0 milestone May 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants