Skip to content

Nested 500 page inside a page #24104

@HesterG

Description

@HesterG

Description

The position of 500 error might be incorrect if an error occurs inside a nested template. In the example below, the error occurs in line 694 of comments.tmpl, and this 500 error page was nested around this place where the error occurs.

default.mov

Steps to reproduce:

  1. Create a team under an organization with the following settings

截屏2023-04-13 17 27 11

  1. Open a pull request and assign the team as the reviewer.

截屏2023-04-13 17 32 27

  1. Delete this team.
  2. Go back to the pull request where this team was formerly assigned.

And the following JS error occurs because when the 500 error page is nested, there will be two head_script.tmpl with webcomponents.js imported twice. This error will be fixed if 500 page is not nested.

截屏2023-04-13 17 47 40

Gitea Version

latest

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

On macOS:

TAGS="bindata sqlite sqlite_unlock_notify" make build
./gitea

Database

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions