Allow force pushing to protected branch

[timbze]

Feature Description

At this point you can only force push when a branch is not protected.

Once a branch is protected, it can be limited like this:

1. no pushes
2. all with write access can push
3. only white-listed users can push

Under option 3 (next to "Whitelist deploy keys..."), I would like an additional check box: "Allow force pushing by whitelisted users"

Screenshots

No response

[henrygoodman]

Bump, I have a workflow where I revert a squash commit if some CI tests fail, and I am unable to push normally (because the tip is behind the remote counterpart), and cannot force push due to branch protection.

Add a checkbox to also allow force push

[henrygoodman]

TY @lunny, would also just suggest (the original proposal could seem a bit ambiguous due to a differentiation between users and deploy keys) that whitelisted deploy keys should have access to force push, as well as whitelisted users (if this is a common workflow for CI, then it is likely people are using SSH/Deploy keys for their git creds)

gh ref:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches

[sebastian-sauer]

Setting in gh:

[sebastian-sauer]

I'd like to implement this feature.

Some questions:

Easiest would be to just add a new option "allow force pushes". This would allow everyone with push access to force push, too.

Github allows to additionally specify the users/teams or Everyone.

What do you think - is a simple "Allow" enough or should we implement it like github?

[henrygoodman]

Trying to pick this up since a bit stale, how about something like this?

I don't think it is enough to have a toggle to allow all whitelisted users to also force-push, as use cases of force-push usually require a subset of whitelisted users with push access. Thus, it makes more sense to specify force-push whitelisted users more distinctly (i.e. specify exactly which users can force-push, but also have the option to allow all whitelisted users to force-push)

I think the section should always be enabled, i.e. be toggleable (even if Push is disabled), as it just specifies who can force push given that set of users has push access (even if no users currently have push access).

• Default option when toggled is Everyone
• Everyone means every user with push access
• Whitelisted force-pushing also requires the same user/team to be whitelisted for push access, but this is not enforced. Users will just get an error if they attempt to force push without also having normal push access.

[henrygoodman]

I'm just going to start implementing above and make any changes based on PR feedback 👍

[SoulSeekkor]

Looking forward to this, I have to force push rarely but it's annoying to have to rename a rule to do it and rename it back after it's pushed every time.

[henrygoodman]

PR is raised now, note the UI isn't precisely what I originally had in mind, due to how the template handles the logic, and it was a lot easier to implement in a similar fashion to the Push section. Regardless, it should still function as expected

[Urth]

The proposed change is the only way to have functional feature branches that enforce signed commits. I would love to see this fixed. (the signed commit requirement is exclusive to protected branches...)