Releases didn't display

[lunny]

see https://try.gitea.io/lunny/core/releases for examples. This repo is migrated from https://github.com/go-xorm/core. The counter is 8, but nothing listed.

[ethantkoenig]

The problem is that the count is computed using GitRepo.NumTags(), whereas the list of releases is computed using the database. During the migration, the repo's tags are preserved, but no corresponding releases are added to the database.

We also don't generate/delete releases when tags are added/deleted. It seems there are two options

1. Enforce a one-to-one correspondence between releases and tags, by generating/deleting releases in the database when tags are added/deleted (including tags added during a migration)
2. Don't enforce such a one-to-one correspondence, and just compute the count using the DB. This seems like the easier option.

[lafriks]

I think the first option would be needed as otherwise mirrors will be missing releases

[lunny]

As @lafriks said, I like the first option

[lunny]

If we chose option 2, we need a new tab named tags. Tags is different with Releases, user could create Releases on Tags, user also could upload files to create Releases.

[lafriks]

@lunny I plan to work on first option

[sapk]

@lafriks any news ?
We could stick with option 1 we list tags and releases under release. Just if we found a release matching tag we display the attachements and formatted message in place of just the short message of tag. I think github does the same (even wrap successive tags without corresponding release).

[lafriks]

@sapk I'm working on it, hope to finish on weekend

[lunny]

@lafriks option 2 maybe an easier one. When importing, we can create release for every tags and inserted to databases. And on v1.3 we can add tags on Source, so that a release could be created from a tag. It's different from Github but more clear. And also it's easy to implement public release of private repo.

[lunny]

@lafriks since release/v1.2 created, please rebase and send PR to that branch.

[sapk]

@lunny I would say keep on master and backport.

[lafriks]

I will keep it to master and then backport

[lunny]

@sapk @lafriks yes, you are right!