Skip to content

Show info if Maintainers are allowed to edit the Pull #21280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6543 opened this issue Sep 27, 2022 · 5 comments · Fixed by #33738
Closed

Show info if Maintainers are allowed to edit the Pull #21280

6543 opened this issue Sep 27, 2022 · 5 comments · Fixed by #33738
Labels
hacktoberfest topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Milestone
1.24.0

Comments

@6543
Copy link
Member

6543 commented Sep 27, 2022

at the moment we only show the pull creator a checkbox but maintainers have no idea beside try to push to detect if it's enabled or not in UI
@6543 6543 added topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance labels Sep 27, 2022
@6543 6543 added this to the 1.18.0 milestone Sep 27, 2022
@6543
Copy link
Member Author

6543 commented Sep 27, 2022 •
edited
Loading

I propose to display checkbox but grey-out for those who cant change ...
... with a mouse hover over to show info why it's grey-out

@26tanishabanik
Copy link

@6543 , I would like to work on this issue, can you guide me?

@6543
Copy link
Member Author

6543 commented Oct 6, 2022 •
edited
Loading

the feature was added with #18002 ... there you can find the initial template changes

so https://github.com/go-gitea/gitea/pull/18002/files#diff-dacece2bf48efcf3ffe10ecc5aa7166ec77341638c790a2521c29480311c1714 has to be altered

@lunny lunny modified the milestones: 1.18.0, 1.19.0 Oct 17, 2022
@lunny lunny modified the milestones: 1.19.0, 1.20.0 Feb 5, 2023
@delvh delvh removed this from the 1.20.0 milestone Jun 7, 2023
@kuraga
Copy link

kuraga commented Oct 15, 2024

have no idea beside try to push

And where to push?

@wxiaoguang wxiaoguang mentioned this issue Feb 27, 2025
Merged
@wxiaoguang
Copy link
Contributor

-> Show info about maintainers are allowed to edit a PR #33738

@lunny lunny closed this as completed in 01156f9 Feb 27, 2025
@lunny lunny added this to the 1.24.0 milestone Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest topic/ui Change the appearance of the Gitea UI topic/ui-interaction Change the process how users use Gitea instead of the visual appearance
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Show info about maintainers are allowed to edit a PR wxiaoguang/gitea
6 participants
@lunny @kuraga @wxiaoguang @6543 @26tanishabanik @delvh