Clicking on "Viewed" on a PR after "Show more" doesn't work #21228
Comments
|
Maybe related to this one: Update: the newly loaded files have incorrect |
wxiaoguang
added a commit
that referenced
this issue
Sep 21, 2022
…21230) The problem was that many PR review components loaded by `Show more` received the same ID as previous batches, which confuses browsers (when clicked). All such occurrences should now be fixed. Additionally improved the background of the `viewed` checkbox. Lastly, the `go-licenses.json` was automatically updated. Fixes #21228. Fixes #20681. Co-authored-by: wxiaoguang <[email protected]>
delvh
added a commit
to delvh/gitea
that referenced
this issue
Sep 21, 2022
…o-gitea#21230) The problem was that many PR review components loaded by `Show more` received the same ID as previous batches, which confuses browsers (when clicked). All such occurrences should now be fixed. Additionally improved the background of the `viewed` checkbox. Lastly, the `go-licenses.json` was automatically updated. Fixes go-gitea#21228. Fixes go-gitea#20681. Co-authored-by: wxiaoguang <[email protected]>
techknowlogick
pushed a commit
that referenced
this issue
Sep 23, 2022
…21230) (#21234) Backport of #21230 The problem was that many PR review components loaded by `Show more` received the same ID as previous batches, which confuses browsers (when clicked). All such occurrences should now be fixed. Additionally improved the background of the `viewed` checkbox. Fixes #21228. Fixes #20681. Co-authored-by: wxiaoguang <[email protected]> Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Hello, when reviewing a PR with a lot of files, only some files are displayed. After clicking on "Show more" at the bottom of the page, if you click on "Viewed" on the first of the newly displayed files, it is the first file of the page that has its "viewed checkbox" checked/unchecked. Same happens on the second newly displayed file, it is the second file of the page that is changed.
When clicking on the checkbox and not the label, it works though.
You can reproduce it here : https://try.gitea.io/vtaix/test/pulls/1/files
Screenshots
Gitea Version
1.17.1
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
Ubuntu 20.04
Browser Version
Firefox 104.0
The text was updated successfully, but these errors were encountered: