Git-Hook for update does not get the refname, oldrev, newrev as parameter

[TomFreudenberg]

• Gitea version (or commit ref): v1.1
• Git version: 2.10.1 (Apple Git-78)
• Operating system: OSX/Ubuntu
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant
• Log gist:

Description

Hi, I have tested some simple scripts from here:

https://git-scm.com/book/uz/v2/Customizing-Git-An-Example-Git-Enforced-Policy

and put that as update-hook via Git-Hooks->update

#!/usr/bin/env ruby

$refname = ARGV[0]
$oldrev  = ARGV[1]
$newrev  = ARGV[2]
$user    = ENV['USER']

puts "Enforcing Policies..."
puts "(#{$refname}) (#{$oldrev[0,6]}) (#{$newrev[0,6]})"

But it seems that the ARGV is empty.

Also a very simple

#!/bin/bash
echo "$1 $2 $3"

doesn't print out anything.

From where in the "hook call" of gitea I will be able to read the refs?

[TomFreudenberg]

Hint from @lunny

maybe this PR will fix that? @TomFreudenberg #1975

[TomFreudenberg]

Hi @lunny thanks for guiding me to that PR. It might resolve my issue too, but I can't test it. The patch cannot be cherry-picked to release/v1.1 branch in case of missing integrations/gitea-integration-meta/gitea-repositories/...

I will check if the master branch is working for me with that applied.

---

Update:

Still no success, the arguments $1, $2, $3 should have been available but they are not.
Seems to me that this might be a bug?

[TomFreudenberg]

Ok, I did a default git test

git create --bare hooks.git

and then put that above ruby example into hooks.git/hooks/update and run a test push.

That works like expected:

git push

Counting objects: 3, done.
Writing objects: 100% (3/3), 304 bytes | 0 bytes/s, done.
Total 3 (delta 0), reused 0 (delta 0)

remote: Enforcing Policies...
remote: (refs/heads/master) (5317c5) (c59a55)

To /tmp/hooks.git
   5317c5f..c59a55c  master -> master

When I put the same hook script into a gitea repository, I get an error, because arguments $1, $2and $3 are empty / not set.

[TomFreudenberg]

Posted originally from @lafriks

Just checked and hooks seems to work just fine.

pre-receive:

#!/bin/sh

read oldrev newrev refname
echo "(pre-receive) Old revision: $oldrev"
echo "(pre-receive) New revision: $newrev"
echo "(pre-receive) Reference name: $refname"

update:

#!/bin/sh

refname="$1"
oldrev="$2"
newrev="$3"

echo "(update) Old revision: $oldrev"
echo "(update) New revision: $newrev"
echo "(update) Reference name: $refname"

post-receive:

#!/bin/sh

read oldrev newrev refname
echo "(post-receive) Old revision: $oldrev"
echo "(post-receive) New revision: $newrev"
echo "(post-receive) Reference name: $refname"

When pushing to repository I get output:

~/tmp/repo1$ git push
Username for 'http://localhost:3000': user1
Password for 'http://user1@localhost:3000': 
Counting objects: 3, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (3/3), 979 bytes | 0 bytes/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote: (pre-receive) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (pre-receive) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (pre-receive) Reference name: refs/heads/master
remote: (update) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (update) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (update) Reference name: refs/heads/master
remote: (post-receive) Old revision: da71e16f337ac6b7beddaa7eada597b4c3357a9e
remote: (post-receive) New revision: 0d3b36185327af7e7a6a4725f9bc2084143838d3
remote: (post-receive) Reference name: refs/heads/master
To http://localhost:3000/user1/repo1.git
   da71e16..0d3b361  master -> master

[TomFreudenberg]

@lunny @lafriks

I still can't reproduce the output from Lauris without doing a patch.

The post-receive and pre-receive hooks are working but not the update hook. I tried this for branch release/v1.1 as well as for master branch.

I have created new repositories all the time via gitea web interface. After that the update hook script of the new repos looks like:

#!/usr/bin/env bash
data=$(cat)
exitcodes=""
hookname=$(basename $0)
GIT_DIR=${GIT_DIR:-$(dirname $0)}

for hook in ${GIT_DIR}/hooks/${hookname}.d/*; do
test -x "${hook}" || continue
echo "${data}" | "${hook}"
exitcodes="${exitcodes} $?"
done

for i in ${exitcodes}; do
[ ${i} -eq 0 ] || exit ${i}
done

But as you can see from your integration meta sources at: https://github.com/go-gitea/gitea/blob/master/integrations/gitea-integration-meta/gitea-repositories/user2/repo1.git/hooks/update#L6

the update hook should have forwarded the params 1 to 3, like

echo "${data}" | "${hook}" $1 $2 $3

If I change the update hook script, then I can reproduce the output from Lauris as well.

Thanks for feedback

[lafriks]

Did you try running update hooks from administration interface?

[TomFreudenberg]

Hi @lafriks, what does that mean?

try running update hooks from administration interface?

I do the following:

1. Connect Web Browser to gitea web
2. Login as user with rights to manage githooks
3. Create a new repository through Button "Create -> New Repository" and create a README.md by default
4. Go to settings for the new repo and entering the update hook script
5. Copy/Paste your code and save
6. See "green" info about active hook
7. Change to a terminal
8. Clone ssh://localhost/my-new-repo
9. cd cloned-path
10. Change content of README.md and commit
11. Push to origin and check the console output

[lafriks]

@TomFreudenberg, I'm sorry I was testing with code I did some fixes 😆. On master it does not work, I'll create PR that does fix this problem