Skip to content

Username should be able to be an email address (again) #17757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wolfaba opened this issue Nov 22, 2021 · 3 comments
Closed

Username should be able to be an email address (again) #17757

wolfaba opened this issue Nov 22, 2021 · 3 comments
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@wolfaba
Copy link

wolfaba commented Nov 22, 2021

Feature Description

We would really like to use email address as username. Would this be possible?

I have already found #4030 but

  • we do have sAMAccountName as Firstname.Lastname, but for users with long name, there is not complete name. Email is for everyuser complete.
  • we have two different users with the same firstname and lastname, but in different domain, i.e. sAMAccountName is generated, but the email is still different
  • for most other service already use email address and we have startet to use email address instead of our uid because most external services use email address and we don't want from users to remember on which service they have to login with what account

Thank you for new consideration.

Regards,

Robert Wolf.

Screenshots

No response

@Gusted Gusted added type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Nov 22, 2021
@lunny
Copy link
Member

lunny commented Nov 22, 2021

I think currently you could login with user's emails. If the login name is an email address, it may conflicts with login with emails.

@Gusted
Copy link
Contributor

Gusted commented Nov 22, 2021

it may conflicts with login with emails.

Related: #4030 (comment)

@wolfaba
Copy link
Author

wolfaba commented Nov 22, 2021

Hmmm, strange. We have tested this today morning and we got error Failed to login 'firstname.lastname@domain' via 'Actice Directory': User name is invalid [firstname.lastname@domain]: must be valid alpha or numeric or dash(-_) or dot characters, but probably there was some caching and we have not removed existing account after changing LDAP auth options.
Now, we can login with email using filter (mail=%s). The username attribute must be one without at-sign, we cannot user mail attribute, but we can use sAMAccountName.
Sorry for this question.

@wolfaba wolfaba closed this as completed Nov 22, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/enhancement An improvement of existing functionality type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

3 participants