-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Empty envelope sender in mail notifications #17477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
zeripath
added a commit
to zeripath/gitea
that referenced
this issue
Oct 28, 2021
Sometimes it may be advisable to hide or alias the from address on an SMTP mail envelope. This PR adds two new options to the mailer to allow setting of an overriding from address. Fix go-gitea#17477 Signed-off-by: Andrew Thornton <[email protected]>
wxiaoguang
pushed a commit
that referenced
this issue
Nov 19, 2021
* Add settings to allow different SMTP envelope from address Sometimes it may be advisable to hide or alias the from address on an SMTP mail envelope. This PR adds two new options to the mailer to allow setting of an overriding from address. Fix #17477 Signed-off-by: Andrew Thornton <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this issue
Mar 28, 2022
…17479) * Add settings to allow different SMTP envelope from address Sometimes it may be advisable to hide or alias the from address on an SMTP mail envelope. This PR adds two new options to the mailer to allow setting of an overriding from address. Fix go-gitea#17477 Signed-off-by: Andrew Thornton <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Mail notifications sent by Gitea (like info about being added to repo as collaborator, checked in v1.13) have nonempty envelope sender which may generate unnecessary bounces in case of delivery problems. Now address configured in
generates messages with
Consider setting empty envelope sender which is allowed i.e. for bounces to avoid loops
https://datatracker.ietf.org/doc/html/rfc5321#section-4.1.1.2
With empty envelope sender messages should contain
Not sure but places to be modified are:
https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L245
https://github.com/go-gitea/gitea/blob/main/services/mailer/mailer.go#L213
Screenshots
No response
The text was updated successfully, but these errors were encountered: