Skip to content

Inline comments in code tab missing first comment #13528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
silverwind opened this issue Nov 12, 2020 · 3 comments
Closed

Inline comments in code tab missing first comment #13528

silverwind opened this issue Nov 12, 2020 · 3 comments
Labels
type/bug

Comments

@silverwind
Copy link
Member

silverwind commented Nov 12, 2020 •
edited
Loading

On the conversation tab (https://gitea.com/macaron/i18n/pulls/7):

image

On the code tab (https://gitea.com/macaron/i18n/pulls/7/files):

image
@lunny lunny added the type/bug label Nov 12, 2020
@lafriks
Copy link
Member

lafriks commented Nov 15, 2020

yaeh I think this happens when commet becomes outdated?

@zeripath
Copy link
Contributor

And should have been fixed by #13448

@lunny lunny closed this as completed Nov 16, 2020
@silverwind
Copy link
Member Author

silverwind commented Nov 16, 2020 •
edited
Loading

Don't think it's fixed. gitea.com is at 5d932b3 which should include your fix from b091c99 but I still see the issue in the linked example.

@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @silverwind @lafriks @zeripath