Damaged graph

[a-n-dokuchaev]

• Can you reproduce the bug at https://try.gitea.io:
  • Yes (URL)
  • No
  • Not relevant

Description

We have damaged graph on some projects. This is very disturbing. Thanks.

Screenshots

[lunny]

Could you give more details?

[a-n-dokuchaev]

The graph is disappearing after doing some merges or pushing local branches. It's the only thing we know. We found 5/100+ of our repos with the same state as on the try.gitea.io.

[zeripath]

Looking at the browser inspector console I see:

jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1 jQuery.Deferred exception: Cannot read property 'color' of undefined TypeError: Cannot read property 'color' of undefined
    at https://try.gitea.io/js/gitgraph.js:1:4466
    at n (https://try.gitea.io/js/gitgraph.js:1:4703)
    at https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:67748
    at l (https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:255165)
    at Generator._invoke (https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:254918)
    at Generator.forEach.e.<computed> [as next] (https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:255522)
    at n (https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:553357)
    at s (https://try.gitea.io/js/index.js?v=798fb62373ca0ec978de1f0f5e229f0f:1:553568) undefined
C.Deferred.exceptionHook @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
c @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
(anonymous) @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
Promise.then (async)
l @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
c @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
setTimeout (async)
(anonymous) @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
u @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
fireWith @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
fire @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
u @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
fireWith @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
ready @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
_ @ jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1
jquery.js?v=798fb62373ca0ec978de1f0f5e229f0f:1 Uncaught TypeError: Cannot read property 'color' of undefined
    at gitgraph.js:1
    at n (gitgraph.js:1)
    at gitgraph.js:12
    at l (runtime.js:45)
    at Generator._invoke (runtime.js:274)
    at Generator.forEach.e.<computed> [as next] (runtime.js:97)
    at n (asyncToGenerator.js:3)
    at s (asyncToGenerator.js:25)

[zeripath]

running with: make watch-frontend in the console I see:

jquery.js?v=d6ca3c6360663dfd3a697d1a6e4ed792:4150 Uncaught TypeError: Cannot read property 'color' of undefined
    at draw (gitgraph.js:519)
    at gitGraph (gitgraph.js:557)
    at _callee$ (to-absolute-index.js:11)
    at tryCatch (to-absolute-index.js:11)
    at Generator.invoke [as _invoke] (to-absolute-index.js:11)
    at Generator.prototype.<computed> [as next] (to-absolute-index.js:11)
    at asyncGeneratorStep (to-absolute-index.js:11)
    at _next (to-absolute-index.js:11)

Line 519 (to the browser) appears to match up with:

gitea/web_src/js/vendor/gitgraph.js

Line 380 in d31a9c5

color = flows[colomnIndex].color;

[zeripath]

It appears the problem is that the git graph is not in the format that this js function seems to expect.

The js seems to expect the use of underscores and not hyphens...

If I bodge in code to handle hyphens the problem goes away.

Now I'm not sure why this is different but my build of git 1.7.2 appears to use hyphens so perhaps this has always been broken?!

---

Edit:

I suspect it has

bluef/gitgraph.js#6