wiki function of migrated repo result in 500

[w6m6]

• Gitea version (or commit ref):
• Git version: 1.11.2
• Operating system: Centos 7
• Database (use [x]):
  • PostgreSQL
  • [ X] MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • [X ] No
  • Not relevant
• Log gist:

Description

when we create a repo using New Migration function, the wiki of migrated repo results in 500, logs of gitea goes for
2020/03/19 17:55:20 routers/repo/wiki.go:134:renderViewPage() [E] GetBranchCommit: reference not found
while when create a new repo. the wiki of new repo works correctly.

Screenshots

[lunny]

Could you try v1.11.3?

[w6m6]

upgrade to 1.11.3 remains the same error.
By the way, the repo was migrated from gitlab.

[lunny]

@w6m6 Is that a private repository or a public one? If it's a public one. could you paste that link here?

[w6m6]

it's an internal repo, i'm afraid that i could only provide the log files if necessary. :(

[zeripath]

I suspect this is fixed by #10676 - which I will backport presently.

[lunny]

@zeripath It's a wiki related problem, maybe not.

[zeripath]

@lunny the issue is that the code explicitly checks if the ref does not exist expecting a git.ErrNotExists (or the like) but actually it receives a plumbing.ErrRefNotExists (again exact name I can't remember) this means that a server error is called instead of the error being handled.

@w6m6 would it be possible for you to check on the release/v1.11 or master branches that this is fixed?

[w6m6]

@zeripath sorry，i dont have a compile env currently. We could take it a try if there is a binary file.

[w6m6]

@zeripath It seemed that this bug was fixed in the latest version 1.11.4. thx a lot.