Skip to content

[Bug] GetDiverging(pull) can lock pull in a 500 state #10117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
6543 opened this issue Feb 3, 2020 · 1 comment · Fixed by #10905
Closed

[Bug] GetDiverging(pull) can lock pull in a 500 state #10117

6543 opened this issue Feb 3, 2020 · 1 comment · Fixed by #10905
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.12.0

Comments

@6543
Copy link
Member

6543 commented Feb 3, 2020

if zwo threads add remote repo to pullBase repo they can lock it

2020/02/03 02:47:28 routers/repo/pull.go:392:PrepareViewPullInfo() [E] GetDiverging: headGitRepo.AddRemote: exit status 128 - fatal: remote tmp-pull-4206-base already exists.
https://gitea.com/gitea/go-sdk/pulls/256
@lunny lunny added the type/bug label Feb 3, 2020
@lunny lunny added this to the 1.12.0 milestone Feb 3, 2020
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 3, 2020
@6543
Copy link
Member Author

6543 commented Feb 3, 2020

solution: use a tempRepo to compare base & head repo ...

-> but to save resorces we need a cahcke or precalc the values on each push to pull

move this "task" to checkPullTask?

@6543 6543 mentioned this issue Mar 31, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.12.0
Development

Successfully merging a pull request may close this issue.

Prevent deadlock in pull_service.GetDiverging(pr) 6543-forks/gitea
2 participants
@lunny @6543