-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
@@ -23,7 +23,7 @@ There are some steps to do so below. On Unix run as your Gogs user: | |||
* Download the file matching your platform from the [downloads page](https://dl.gitea.io/gitea) | |||
* Put the binary at the desired install location | |||
* Copy `gogs/custom/conf/app.ini` to `gitea/custom/conf/app.ini` | |||
* If you have custom `templates, public` in `gogs/custom/` copy them to `gitea/custom/`. | |||
* If you have custom `templates, public` in `gogs/custom/` copy them to `gitea/custom/` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the indication could go here directly, like adding: "(or do this in a second step and incrementally because your custom templates might not be compatible with new code anymore)"
@@ -61,6 +61,9 @@ ROOT_PATH = /home/:USER/gitea/log | |||
``` | |||
|
|||
* Verify by starting Gitea with `gitea web` | |||
|
|||
### Troubleshooting | |||
- If you encounter errors relating to custom templates in the `gitea//custom/templates` folder, try deleting `gitea/custom/templates`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deleting seems a bit excessive, maybe "move away" ?
Beside the comments, which are suggestions to improve the change, it still LGTM to add a troubleshooting section :) |
@strk Updated. |
Still fine with me, although I liked the "troubleshooting" section (given you won't know upfront if your templates are compatible, but might instead get a panic crash on first use...) |
Troubleshooting section reinstated |
Great! Now we need another maintainer to review and a merger to merge ... (slooooow burocracy) |
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove an unnecessary empty line.
### Troubleshooting | ||
* If you encounter errors relating to custom templates in the `gitea//custom/templates` folder, try moving the templates causing the errors away one by one. They may not be compatible with Gitea. | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove an unnecessary empty line.
|
||
|
||
### Troubleshooting | ||
* If you encounter errors relating to custom templates in the `gitea//custom/templates` folder, try moving the templates causing the errors away one by one. They may not be compatible with Gitea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing new line before this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double slash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the double forward slash, but I don't understand "Missing new line before this"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new line between content and headline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tboerger fixed
@sbrl please resolve the conflict |
@strk There's a conflict? Where? I feel like I'm missing something here |
|
@appleboy Ah! I see. It right there in the github interface. Sorted! I don't know what it was complaining about :P |
LGTM |
Awesome~! 😄 |
Added troubleshooting tip, as per the gitter conversation.