Skip to content

WIP fix(gnovm): post optimization to #2077 #4238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ltzmaxwell
Copy link
Contributor

fix some issues introduced by 2077.

@ltzmaxwell ltzmaxwell marked this pull request as draft April 30, 2025 15:32
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Apr 30, 2025
@ltzmaxwell ltzmaxwell changed the title fix(gnovm): post optimization to #2077 WIP fix(gnovm): post optimization to #2077 Apr 30, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 30, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: ltzmaxwell/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

Attention: Patch coverage is 91.89189% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/preprocess.go 91.89% 4 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@jaekwon jaekwon changed the base branch from master to fix/crossrealm/xform May 19, 2025 22:49
@jaekwon jaekwon changed the base branch from fix/crossrealm/xform to master May 19, 2025 22:53
@Kouteki Kouteki moved this from In Progress to Todo in 🧙‍♂️gno.land core team Jun 2, 2025
@ltzmaxwell
Copy link
Contributor Author

close as already finished. see "TRANS_SKIP" stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants