Skip to content

feat: scan memory, reset allocator #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat: scan memory, reset allocator #3148

wants to merge 3 commits into from

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Nov 18, 2024

This is as an alternative solution to garbage collection to reclaim memory.
If an allocation is about to fail, walk all blocks in the machine and their values and recalculate how much memory is used.

This issue has been taken over by @ltzmaxwell .

@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 11.36364% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/pkg/gnolang/alloc.go 2.50% 38 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@petar-dambovaliev
Copy link
Contributor Author

Pending @jaekwon's approval for this approach and i will add tests for this functionality.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 3, 2024

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@zivkovicmilos
Copy link
Member

Logging here for visibility:
#3458

@Kouteki Kouteki removed the in focus label Feb 3, 2025
@Kouteki
Copy link
Contributor

Kouteki commented Feb 17, 2025

Stale, closing

@Kouteki Kouteki closed this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Development

Successfully merging this pull request may close these issues.

5 participants