Feature: Add Python 3.13 to CI #54
Conversation
WalkthroughThe pull request introduces support for Python 3.13 across the project's testing and packaging configurations. This involves updating the GitHub Actions workflow to include Python 3.13 in the test matrix and expanding the project's Python version classifiers in the Changes
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/test.yml (1)
Line range hint
10-23: Consider matrix.fail-fast strategy for development PythonSince Python 3.13 is still in development, consider adding
fail-fast: falseto prevent the entire matrix from failing if 3.13 tests fail.strategy: + fail-fast: false matrix: python:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/test.yml(1 hunks)setup.py(1 hunks)
🔇 Additional comments (2)
setup.py (1)
40-44: Verify Python 3.13 compatibility and consider development statusThe addition of Python version classifiers looks good, but since Python 3.13 is still in development:
- Consider adding an alpha/beta classifier to indicate experimental support
- Ensure all dependencies in requirements.txt are compatible with Python 3.13
Run this script to check requirements compatibility:
✅ Verification successful
Dependencies are compatible with Python 3.13
All dependencies in requirements.txt support Python 3.13 as they only specify minimum Python versions without upper bounds:
- deprecated: >=2.7
- requests-oauthlib: >=3.4
- requests: >=3.8
The Python 3.13 classifier can be safely added without additional Development Status classifier as the dependencies pose no compatibility issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check if any requirements specify Python version constraints rg "python_version|python_requires" requirements.txt || echo "No Python version constraints found in requirements.txt" # List requirements for manual verification cat requirements.txtLength of output: 202
Script:
#!/bin/bash # Check PyPI metadata for Python version support for pkg in "deprecated" "requests-oauthlib" "requests"; do echo "=== $pkg ===" # Use gh api to query PyPI API for the latest version info curl -s "https://pypi.org/pypi/$pkg/json" | jq -r '.info | {requires_python, version}' doneLength of output: 804
.github/workflows/test.yml (1)
23-23: Consider updating runner and action versions for Python 3.13While adding Python 3.13 is good, consider these improvements:
- Update to a newer Ubuntu runner (e.g., ubuntu-latest) for better Python 3.13 support
- Verify if actions/setup-python@v4 supports Python 3.13
- runs-on: ubuntu-20.04 + runs-on: ubuntu-latest✅ Verification successful
Update to newer Ubuntu runner for consistency
The suggestion to update to a newer Ubuntu runner is valid, as other workflows in the repository already use
ubuntu-22.04orubuntu-latest. However, actions/setup-python@v4 is appropriate and doesn't need updating, as it's the latest major version and handles Python installation independently of the runner.- runs-on: ubuntu-20.04 + runs-on: ubuntu-latest🏁 Scripts executed
The following scripts were executed for the analysis:
Error: No shell scripts found
Script:
#!/bin/bash # Check the complete workflow file cat .github/workflows/test.yml # Look for any other workflow files that might have Python configurations fd -e yml -e yaml . .github/workflows/Length of output: 970
Script:
#!/bin/bash # Check other workflow files for Python configurations cat .github/workflows/docs-upload.yml cat .github/workflows/pypi.yml cat .github/workflows/tagged-release.ymlLength of output: 4052
No description provided.